mirror of
https://gitea.com/gitea/gitea-mcp.git
synced 2026-08-03 15:49:23 +02:00
silverwind
0dc9868e2e
Review follow-ups on the SDK migration. An "arguments": null is what clients send for parameterless tools like get_me, and what mcp-go accepted by returning a nil map. The new adapter rejected it with InvalidParams, which broke those calls outright. The /mcp endpoint took unlimited request bodies and never expired idle sessions, so a peer that goes away without DELETE kept its session for the process lifetime. Both are reachable before any token check, so neither can stay unbounded; the body cap sits above the SDK default to leave room for the base64 content create_or_update_file accepts. Required() smuggled a bool through the property schema map and deleted it again, colliding with the JSON Schema keyword of the same name. It now sets a field on Property, so an object property can carry its own required list. The tool contract fixture cost a manual regeneration step and four hand-maintained counts on every tool change, and a snapshot freezes defects rather than reporting them. Property assertions cover the same surface and reject a duplicate tool name, a readOnlyHint that disagrees with the register call, and a default that contradicts its own type or enum. Co-Authored-By: Claude (Opus 5) <noreply@anthropic.com>
72 lines
2.0 KiB
Go
72 lines
2.0 KiB
Go
package tool
|
|
|
|
import (
|
|
"reflect"
|
|
"testing"
|
|
|
|
"github.com/modelcontextprotocol/go-sdk/mcp"
|
|
)
|
|
|
|
func TestNewDefinition(t *testing.T) {
|
|
annotations := &mcp.ToolAnnotations{Title: "Example", ReadOnlyHint: true}
|
|
definition := NewDefinition(
|
|
"example",
|
|
"Example tool",
|
|
annotations,
|
|
String("owner", Required(), Description("repository owner"), Enum("one", "two"), Default("one")),
|
|
Number("page", Required(), Default(1), Minimum(1)),
|
|
Boolean("draft"),
|
|
Array("labels", Items(map[string]any{"type": "string"})),
|
|
Object("inputs", Description("workflow inputs")),
|
|
)
|
|
|
|
if definition.Name != "example" || definition.Description != "Example tool" {
|
|
t.Fatalf("definition = %#v", definition)
|
|
}
|
|
if definition.Annotations != annotations {
|
|
t.Fatal("NewDefinition did not preserve annotations")
|
|
}
|
|
|
|
want := map[string]any{
|
|
"type": "object",
|
|
"properties": map[string]any{
|
|
"owner": map[string]any{
|
|
"type": "string",
|
|
"description": "repository owner",
|
|
"enum": []string{"one", "two"},
|
|
"default": "one",
|
|
},
|
|
"page": map[string]any{
|
|
"type": "number",
|
|
"default": 1,
|
|
"minimum": float64(1),
|
|
},
|
|
"draft": map[string]any{"type": "boolean"},
|
|
"labels": map[string]any{
|
|
"type": "array",
|
|
"items": map[string]any{"type": "string"},
|
|
},
|
|
"inputs": map[string]any{
|
|
"type": "object",
|
|
"properties": map[string]any{},
|
|
"description": "workflow inputs",
|
|
},
|
|
},
|
|
"required": []string{"owner", "page"},
|
|
}
|
|
if !reflect.DeepEqual(definition.InputSchema, want) {
|
|
t.Errorf("InputSchema = %#v, want %#v", definition.InputSchema, want)
|
|
}
|
|
}
|
|
|
|
func TestNewDefinitionWithoutRequiredProperties(t *testing.T) {
|
|
definition := NewDefinition("empty", "", nil)
|
|
schema := definition.InputSchema.(map[string]any)
|
|
if _, ok := schema["required"]; ok {
|
|
t.Errorf("InputSchema unexpectedly contains required: %#v", schema)
|
|
}
|
|
if got := schema["properties"]; !reflect.DeepEqual(got, map[string]any{}) {
|
|
t.Errorf("properties = %#v, want empty map", got)
|
|
}
|
|
}
|